perf: slight optimization on merge states #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit msg is interesting :P |
|
never mind :) |
Yard1
reviewed
Jun 28, 2024
|
|
||
| vec_t<float, vec_size> v_merged_vec; | ||
| v_merged_vec.fill(0.f); | ||
| if (num_index_sets > 1) { |
There was a problem hiding this comment.
wouldn't it be cleaner to just early return instead of indenting everything?
There was a problem hiding this comment.
yes you are right, thanks for your suggestion.
yzh119
force-pushed
the
stupid-optimization-on-merge-states
branch
from
90e5473 to
cf7a7d4
Compare
yzh119
force-pushed
the
stupid-optimization-on-merge-states
branch
from
cf7a7d4 to
a8bc999
Compare
yzh119
added a commit
that referenced
this pull request
Jul 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.2](v0.1.1...v0.1.2) (2024-07-29) ### Bugfix * Fix the sampling kernel bug for cu118 ([#386](#386), [#387](#387)) ([0cd499](0cd4994), [dc3f18](dc3f184)) ### Features * add llama 3.1 style rope ([#401](#401)) ([4c89dec](4c89dec)) * non-inplace rope operators ([#405](#405)) ([74ffba1](74ffba1)) * sliding window attention ([#406](#406)) ([28cffd3](28cffd3)) * support non-contiguous (packed) input for prefill kernels ([#404](#404)) ([68c3719](68c3719)) ### Performance Improvements * slight optimization on merge states ([#313](#313)) ([701c813](701c813)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Zihao Ye <expye@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cudagraph is enabled, we will still call merge states kernels for short sequence length, which incurs some unnecessary overhead.
This PR accelerates merge states kernel when there is nothing to merge (
num_index_sets=1).We can actually write through to the target buffer for small sequence length, but I'm always lazy evaluated and I'll leave it for a future PR (if necessary).